Lunderberg commented on code in PR #15689: URL: https://github.com/apache/tvm/pull/15689#discussion_r1397529003
########## include/tvm/relax/utils.h: ########## @@ -110,6 +110,11 @@ TVM_DLL Function CopyWithNewVars(Function func); */ Expr ToNonDataflow(const Expr& e); +/*! + * \brief Get the value bound in the binding. + */ +Expr GetBoundValue(const Binding& b); Review Comment: If you'd like, https://github.com/apache/tvm/pull/15992 has an implementation of hoisting the `value` field to `BindingNode`, which was [passing all unit tests](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-unity/detail/PR-15992/1/pipeline/). I closed it after feedback, but it could be worth revisiting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
