Lunderberg commented on code in PR #15689: URL: https://github.com/apache/tvm/pull/15689#discussion_r1409479520
########## include/tvm/relax/analysis.h: ########## @@ -404,6 +404,18 @@ TVM_DLL Map<Var, Array<Var>> DataflowBlockUseDef(const DataflowBlock& dfb); */ std::pair<Map<Var, Array<Var>>, Array<Var>> FunctionUseDef(const Function& fn); +/*! + * \brief Perform a liveness analysis on the function, indicating which variables + * are live at which location in the function. + * + * \param fn The function to be analyzed. Review Comment: Good point. I usually lean toward member functions, because they are much easier for a developer to discover, and avoid requiring long names to provide enough context to a reader. It would be nice if there were something similar to the extension methods of C# or Rust, to allow the improved readability without making monolithic classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
