slyubomirsky commented on code in PR #15689: URL: https://github.com/apache/tvm/pull/15689#discussion_r1408677561
########## include/tvm/relax/analysis.h: ########## @@ -404,6 +404,18 @@ TVM_DLL Map<Var, Array<Var>> DataflowBlockUseDef(const DataflowBlock& dfb); */ std::pair<Map<Var, Array<Var>>, Array<Var>> FunctionUseDef(const Function& fn); +/*! + * \brief Perform a liveness analysis on the function, indicating which variables + * are live at which location in the function. + * + * \param fn The function to be analyzed. Review Comment: It depends on whether we plan to reuse the dataflow analysis framework (I was hoping to but it doesn't sound like there's an immediate candidate for another analysis we would implement with it). If so, the CFG would be needed for many things and we probably wouldn't want to make all of them methods of the class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
