Anndrey24 commented on code in PR #16106:
URL: https://github.com/apache/tvm/pull/16106#discussion_r1399284730


##########
python/tvm/relay/op/strategy/arm_cpu.py:
##########
@@ -242,7 +242,14 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type, 
target):
                             ),
                             name="conv2d_NHWC_quantized_interleaved.arm_cpu",
                         )
-                if (not is_aarch64) or (data.dtype not in ["int8", "uint8"]):
+                # Non-quantized cases
+                if is_aarch64 and data.dtype in ["float32", "float16"]:
+                    strategy.add_implementation(
+                        
wrap_compute_conv2d(topi.arm_cpu.compute_conv2d_NHWC_hybrid),
+                        
wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_NHWC_hybrid),
+                        name="conv2d_NHWC_hybrid.arm_cpu",
+                    )
+                if (not is_aarch64) or (data.dtype not in ["int8", "uint8", 
"float32", "float16"]):

Review Comment:
   That makes sense, I'll make the change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to