ekalda commented on code in PR #16106:
URL: https://github.com/apache/tvm/pull/16106#discussion_r1400918955
##########
python/tvm/relay/op/strategy/arm_cpu.py:
##########
@@ -232,7 +232,7 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type,
target):
wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_NHWC_quantized_native),
name="conv2d_NHWC_quantized_native.arm_cpu",
)
- if is_aarch64 and has_asimd:
+ if has_asimd:
Review Comment:
I'd favour making it explicit in the if else block which combination of
architecture extensions results in which set of schedules added to the
strategy, even though it would create more lines of code. So essentially
recreating that bullet point table there, with both schedules added when both
i8mm and dotprod are available, in the right priority order. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
