ekalda commented on code in PR #16106:
URL: https://github.com/apache/tvm/pull/16106#discussion_r1400707029
##########
python/tvm/relay/op/strategy/arm_cpu.py:
##########
@@ -232,7 +232,7 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type,
target):
wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_NHWC_quantized_native),
name="conv2d_NHWC_quantized_native.arm_cpu",
)
- if is_aarch64 and has_asimd:
+ if has_asimd:
Review Comment:
This condition looks redundant since `has_asimd` is defined as `has_asimd =
is_aarch64 || simd_flag` and we're adding the same schedule to the strategy?
##########
python/tvm/relay/op/strategy/arm_cpu.py:
##########
@@ -250,6 +257,7 @@ def conv2d_strategy_arm_cpu(attrs, inputs, out_type,
target):
wrap_compute_conv2d(topi.arm_cpu.conv2d_nhwc_spatial_pack),
wrap_topi_schedule(topi.arm_cpu.schedule_conv2d_nhwc_spatial_pack),
name="conv2d_nhwc_spatial_pack.arm_cpu",
+ plevel=5,
Review Comment:
For enlightenment, what is the effect of that change and why 5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
