Lunderberg commented on code in PR #16183:
URL: https://github.com/apache/tvm/pull/16183#discussion_r1410855124
##########
include/tvm/runtime/packed_func.h:
##########
@@ -2129,6 +2315,42 @@ struct PackedFuncValueConverter<::tvm::runtime::String> {
}
};
+template <typename T>
+struct PackedFuncValueConverter<Array<T>> {
+ static Array<T> From(const TVMArgValue& val) {
+ auto untyped_array = val.AsObjectRef<Array<ObjectRef>>();
+
+ // Attempt to convert each item of the array into the desired
+ // type. If the items do not require a conversion, no copies are
+ // made.
+ return untyped_array.Map([](ObjectRef item) {
+ // The TVMArgValue is intentionally defined through
Review Comment:
Would this have the correct behavior when `T::ContainerType` is shared among
multiple different `T` types? It's not very common, but `Array<T>`,
`Variant<T...>`, and `tvm::Bool` come to mind.
I think this shortcut would result in arguments `Array<Array<T>>` being
accepted as a parameter `Array<Array<U>>`, leading to segfaults later on when
`U` gets accessed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
