Lunderberg commented on code in PR #16183:
URL: https://github.com/apache/tvm/pull/16183#discussion_r1410949198
##########
include/tvm/runtime/packed_func.h:
##########
@@ -2129,6 +2315,42 @@ struct PackedFuncValueConverter<::tvm::runtime::String> {
}
};
+template <typename T>
+struct PackedFuncValueConverter<Array<T>> {
+ static Array<T> From(const TVMArgValue& val) {
+ auto untyped_array = val.AsObjectRef<Array<ObjectRef>>();
+
+ // Attempt to convert each item of the array into the desired
+ // type. If the items do not require a conversion, no copies are
+ // made.
+ return untyped_array.Map([](ObjectRef item) {
+ // The TVMArgValue is intentionally defined through
+ // `TVMArgsSetter`, rather than defining it with
+ // `value.data_ = item.get();` and type code
+ // `kTVMObjectHandle`. `TVMArgsSetter::operator()` includes
+ // special handling for unwrapping boxed primitives,
+ // PackedFunc, runtime::Module, etc, which should be checked
+ // before delegating to the array element's
+ // PackedFuncValueConverter implementation.
Review Comment:
Sounds good. I changed the comment to describe the use case that it enables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
