Lunderberg commented on code in PR #16569: URL: https://github.com/apache/tvm/pull/16569#discussion_r1506390047
########## tests/python/tvmscript/test_tvmscript_roundtrip.py: ########## @@ -27,8 +27,9 @@ def opt_gemm_normalize(): - @tvm.script.ir_module + @tvm.script.ir_module(check_well_formed=False) Review Comment: I think this is a bug in the well-formed checker. The behavior of a `BufferRealize` node depends on whether it is an externally-provided buffer or not. For an externally-provided buffer, it indicates the region in which the buffer is accessed. For other buffers, it indicates the region for which the buffer must be allocated. So, the well-formed checker should treat `BufferRealize` as a point of definition if the buffer hasn't already been defined. I've submitted https://github.com/apache/tvm/pull/16655, which resolves this issue as well as a few other failures for well-formed checks that have been reported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
