Lunderberg commented on code in PR #16569:
URL: https://github.com/apache/tvm/pull/16569#discussion_r1506401620
##########
tests/python/tir-transform/test_tir_transform_convert_ssa.py:
##########
@@ -327,7 +327,8 @@ class
TestDeDuplicateThreadIdxAcrossMultipleFunctions(BaseBeforeAfter):
def before(self):
threadIdx_x = tvm.tir.Var("threadIdx_x", "int32")
- @I.ir_module
+ # complaints of duplicate definitions of threadIdx_x
+ @I.ir_module(check_well_formed=False)
Review Comment:
I think this one should disable the well formed check. This test is
validating that the pass has correct behavior when resolving SSA violations
across multiple functions. So, the `before` should be ill-formed, but the
`expected` should be well-formed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
