Lunderberg commented on code in PR #16569:
URL: https://github.com/apache/tvm/pull/16569#discussion_r1506403179
##########
tests/python/tir-transform/test_tir_transform_convert_ssa.py:
##########
@@ -350,7 +351,8 @@ def kernel_2(A: T.Buffer([256], "float32")):
return mod
def expected(self):
- @I.ir_module
+ # complaints of duplicate definitions of threadIdx_x
Review Comment:
Can you verify that this occurs in the `expected` and not just the `before`?
The before case should be ill-formed, because `threadIdx_x` is deliberately
defined outside the TIR function and reused, but the expected case defines
`threadIdx_x` inside of each function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
