Lunderberg commented on code in PR #16767: URL: https://github.com/apache/tvm/pull/16767#discussion_r1535691711
########## src/driver/driver_api.cc: ########## @@ -569,15 +569,14 @@ transform::Sequential MixedModulePassManager(IRModule mixed_mod, Target target) Array<Pass> mixed_pass_list; - mixed_pass_list.push_back(tir::transform::FP8ComputeLegalize(target)); + mixed_pass_list.push_back(tir::transform::BindTarget(target)); Review Comment: Can we add a comment here specifying that the `BindTarget` should occur first in this sequence, so that later passes can rely on the target attribute being present? (It looks like both `VerifyVTCMLimit` and `LowerVtcmAlloc` were implemented more recently than `BindTarget`, and probably should have been placed after `BindTarget` at that point.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
