csullivan commented on code in PR #16767: URL: https://github.com/apache/tvm/pull/16767#discussion_r1536237161
########## src/driver/driver_api.cc: ########## @@ -569,15 +569,14 @@ transform::Sequential MixedModulePassManager(IRModule mixed_mod, Target target) Array<Pass> mixed_pass_list; - mixed_pass_list.push_back(tir::transform::FP8ComputeLegalize(target)); + mixed_pass_list.push_back(tir::transform::BindTarget(target)); Review Comment: > > but also, in principle, allows for PrimFuncs with different targets to coexist and be handled correctly by the passes. Here BindTarget is applying the target to all functions in the mixed IRModule, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
