Lunderberg commented on code in PR #16767: URL: https://github.com/apache/tvm/pull/16767#discussion_r1536607793
########## src/driver/driver_api.cc: ########## @@ -569,15 +569,14 @@ transform::Sequential MixedModulePassManager(IRModule mixed_mod, Target target) Array<Pass> mixed_pass_list; - mixed_pass_list.push_back(tir::transform::FP8ComputeLegalize(target)); + mixed_pass_list.push_back(tir::transform::BindTarget(target)); Review Comment: Slight nitpick: All functions that do not already have the target attribute. A function could already have the target attribute, such as defining a module that contains kernels for multiple different targets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
