tqchen commented on code in PR #16569: URL: https://github.com/apache/tvm/pull/16569#discussion_r1535915019
########## src/driver/driver_api.cc: ########## @@ -607,9 +608,6 @@ transform::Sequential MixedModulePassManager(IRModule mixed_mod, Target target) mixed_pass_list.push_back(tir::transform::AnnotateDeviceRegions()); mixed_pass_list.push_back(tir::transform::SplitHostDevice()); - // MergeSharedMemoryAllocations must be applied after SplitHostDevice - // because the merged allocation site is at the beginning of each device function Review Comment: The main reason being here is because we cannot merge dyn share mem across kernel boundary i assume -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
