slyubomirsky commented on code in PR #16569: URL: https://github.com/apache/tvm/pull/16569#discussion_r1525595314
########## tests/python/relax/test_transform_rewrite_cuda_graph.py: ########## @@ -709,7 +709,7 @@ def main(): def test_static_args(): Review Comment: This test case seemed a little concerning to me because the transformation hides the potentially impure packed call in `Before`'s `main` function and also because the `builtin_with_ctx` is not considered pure (maybe we should add a pure override for cases like that)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
