Lunderberg commented on code in PR #16569: URL: https://github.com/apache/tvm/pull/16569#discussion_r1526364085
########## tests/python/relax/test_transform_rewrite_cuda_graph.py: ########## @@ -709,7 +709,7 @@ def main(): def test_static_args(): Review Comment: Agreed, I feel like the `main` function should be marked as impure, because it entirely consists of side effects. I could see a case for having a wrapper function marked as pure, even if it calls impure functions. That's kind of what the `R.call_tir` builtin does, to provide a pure wrapper for an impure TIR function. However, that wouldn't be the case here, as it the `cuda_graph.run_or_capture` function is entirely impure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
