tqchen commented on a change in pull request #5276: [REFACTOR][IR] Move to
runtime::String
URL: https://github.com/apache/incubator-tvm/pull/5276#discussion_r405893661
##########
File path: src/node/serialization.cc
##########
@@ -102,7 +102,7 @@ class NodeIndexer : public AttrVisitor {
for (const auto& kv : n->data) {
MakeIndex(const_cast<Object*>(kv.second.get()));
}
- } else {
+ } else if (!node->IsInstance<StringObj>()) {
Review comment:
Indeed, we should design a special serialization mechanism for String. A
quick idea is to just print out the string content, we can also think about
base64 encoding. I can try to take a stab tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
