zhiics commented on a change in pull request #5276: [REFACTOR][IR] Move to
runtime::String
URL: https://github.com/apache/incubator-tvm/pull/5276#discussion_r405950942
##########
File path: src/relay/transforms/device_annotation.cc
##########
@@ -574,7 +574,7 @@ Pass RewriteAnnotatedOps(int fallback_device) {
return Downcast<Function>(relay::RewriteAnnotatedOps(f, fallback_device));
};
return CreateFunctionPass(pass_func, 1, "RewriteAnnotatedOps",
- {tir::StringImmNode::make("InferType")});
+ {runtime::String("InferType")});
Review comment:
I tried a bit more. It looks we actually need the constructor from `const
char*` in order to make the initializer_list work. Previously, we only have the
constructor from `std::string`. I will add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
