zhiics commented on a change in pull request #5276: [REFACTOR][IR] Move to
runtime::String
URL: https://github.com/apache/incubator-tvm/pull/5276#discussion_r405954029
##########
File path: include/tvm/ir/expr.h
##########
@@ -107,11 +107,12 @@ class PrimExpr : public BaseExpr {
* \param value The value to be constructed.
*/
TVM_DLL PrimExpr(float value); // NOLINT(*)
+
/*!
- * \brief construct from string.
- * \param str The value to be constructed.
+ * \brief construct from runtime String.
+ * \param value The value to be constructed.
*/
- TVM_DLL PrimExpr(std::string str); // NOLINT(*)
+ TVM_DLL PrimExpr(runtime::String value); // NOLINT(*)
Review comment:
Considering the number of files changed so far, I'd like to keep this for
now. It seems a bit more work. I can send a separate PR to handle it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
