tqchen commented on code in PR #18093:
URL: https://github.com/apache/tvm/pull/18093#discussion_r2167386259
##########
CMakeLists.txt:
##########
@@ -384,6 +384,8 @@ if (USE_CUDA AND USE_NVSHMEM)
if (NOT NVSHMEM_FOUND)
message(FATAL_ERROR "Cannot find NVSHMEM, USE_NVSHMEM=" ${USE_NVSHMEM})
endif()
+ set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -I${NVSHMEM_INCLUDE_DIR}
-L${NVSHMEM_LIB_DIR}")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -I${NVSHMEM_INCLUDE_DIR}
-L${NVSHMEM_LIB_DIR}")
Review Comment:
use cmake primitives target_include_directories instead of setting CXX and
CUDA_FLAGS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
