Kathryn-cat commented on code in PR #18093:
URL: https://github.com/apache/tvm/pull/18093#discussion_r2167483510
##########
src/target/source/codegen_cuda.cc:
##########
@@ -297,19 +297,10 @@ std::string CodeGenCUDA::Finish() {
decl_stream << "#define TVM_ENABLE_L2_PREFETCH 0\n";
decl_stream << "#endif\n";
- decl_stream << "\n#ifdef _WIN32\n";
Review Comment:
It's because NVSHMEM contains `#include <cstdint>`, which is in conflict
with the original `#define int64_t long long` and could lead to CUDA
compilation error. The `#define` semantics is quite error prone, so I remove it
and just do `using`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
