Kathryn-cat commented on code in PR #18093:
URL: https://github.com/apache/tvm/pull/18093#discussion_r2167407768
##########
python/tvm/runtime/disco/session.py:
##########
@@ -302,8 +306,6 @@ def load_vm_module(
module : DModule
The loaded VM module.
"""
- if device is None:
- device = Device(device_type=0, device_id=0)
Review Comment:
Yes, in the latest dlpack, `DLDeviceType` has enum values 1 to 17. The
value`Device(device_type=0, device_id=0)` would raise an error of unrecognized
device type. Since it is meant to indicate a Null value, I replace the
subsequent usage with `Optional<Device>` type, see the changes of
`UseDefaultDeviceIfNone`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
