areusch commented on a change in pull request #5417:
URL: https://github.com/apache/incubator-tvm/pull/5417#discussion_r415942734
##########
File path: Makefile
##########
@@ -73,7 +73,10 @@ build/libtvm_web_runtime.js: build/libtvm_web_runtime.bc
cpplint:
python3 3rdparty/dmlc-core/scripts/lint.py vta cpp vta/include vta/src
python3 3rdparty/dmlc-core/scripts/lint.py topi cpp topi/include;
- python3 3rdparty/dmlc-core/scripts/lint.py tvm cpp include src \
+ # Note: exclude src/runtime/micro/host_driven becuase it contains C99
files.
+ python3 3rdparty/dmlc-core/scripts/lint.py tvm cpp \
+ --exclude_path=src/runtime/micro/host_driven \
Review comment:
done. in the long term, we need to figure out whether we extend the dmlc
lint script to not recognize .c files as c++ (this is why I originally excluded
it). for now, the errors are only related to casting so we can leave it on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
