masahi commented on pull request #6232:
URL: https://github.com/apache/incubator-tvm/pull/6232#issuecomment-670850577


   > I think adding `unbiased` argument to variance op will change the 
consistency. It will also bring more work to isolate the variance op from 
reduce ops.
   
   I'm not completely sure what you mean by above, but how about adding 
`VarianceAttrs` with default `unbiased=false`? I think that should fix the 
coupling between variance and reduce op you are referring to?
   
   Anyway, adding two new ops just for the sake of adding `unbiased` support 
sounds a bit overkill to me.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to