masahi edited a comment on pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#issuecomment-670975972
I mean, the new `VarianceAttrs` should also have all attributes of `ReduceAttrs`. The underlying implementation of variance op can continue to be the reduce op. Isn't updating `VarianceCompute` (like you did) and `MakeVariance` (to add `unbiased` param with default False) with corresponding changes in `reduce.py` enough? I don't see why we'd need to register a new shape func to variance op. I don't think it would break anything either. Sorry I didn't look into the details, so I may be missing something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
