shiwenloong commented on pull request #6232: URL: https://github.com/apache/incubator-tvm/pull/6232#issuecomment-671093947
> I mean, the new `VarianceAttrs` should also have all attributes of `ReduceAttrs`. The underlying implementation of variance op can continue to be the reduce op. > > > > Isn't updating `VarianceCompute` (like you did) and `MakeVariance` (to add `unbiased` param with default False) with corresponding changes in `reduce.py` enough? I don't see why we'd need to register a new shape func to variance op. I don't think it would break anything either. > > > > Sorry I didn't look into the details, so I may be missing something. I try the way of of adding `VarianceAttrs` in current implementation. There are fewer problems than I thought. But the inconsistency of `reduce.py` still exists because `std` and `variance` take one more parameter than all other functions in the file. I am not sure if this is a noteworthy issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
