masahi commented on a change in pull request #6314:
URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474243010
##########
File path: tests/python/frontend/pytorch/test_forward.py
##########
@@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):
rtol=1e-5, atol=1e-5)
+def verify_trace_model(traced_model, ishapes, idata=None):
Review comment:
This new function you added is almost identical with
`verfiy_script_model`
https://github.com/apache/incubator-tvm/blob/master/tests/python/frontend/pytorch/test_forward.py#L1578
Please introduce another function, verify_model_on_vm say, to refactor the
common logic of vm execution and verifying
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
