masahi commented on a change in pull request #6314:
URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474253877
##########
File path: tests/python/frontend/pytorch/test_forward.py
##########
@@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):
rtol=1e-5, atol=1e-5)
+def verify_trace_model(traced_model, ishapes, idata=None):
Review comment:
I didn't mean to say remove this particular function, but yeah, since
`verify_model` used by most of other tests are already meant to be used for
traced model, having another `verify_trace_model` doesn't seem right.
Running traced models on VM is a new test case that we haven't had so far,
and there are already some tests (for models jitted by `torch.jit.script`) that
use VM execution, we need a new function that handles
* Traced + VM (new in this PR)
* Scripted + VM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
