masahi commented on a change in pull request #6314:
URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474278914
##########
File path: tests/python/frontend/pytorch/test_forward.py
##########
@@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):
rtol=1e-5, atol=1e-5)
+def verify_trace_model(traced_model, ishapes, idata=None):
Review comment:
yes makes sense, but what I'm imagining is that there would be still
`verify_script_model` and the existing tests that use it shouldn't be touched.
`verify_script_model` would become a simple wrapper around `verify_model_on_vm`.
`verify_model_on_vm` should take already jitted models as input, which can
be both traced or scripted. You shouldn't have `torch.jit.trace` or
`torch.jit.script` inside there. You probably want another wrapper to handle
trace + VM case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
