roastduck commented on a change in pull request #6238:
URL: https://github.com/apache/incubator-tvm/pull/6238#discussion_r476059547
##########
File path: python/tvm/driver/build_module.py
##########
@@ -181,7 +181,7 @@ def lower(sch,
tvm.tir.transform.BF16Legalize(),
tvm.tir.transform.NarrowDataType(32),
tvm.tir.transform.Simplify(),
- tvm.tir.transform.HoistIfThenElse(),
+ tvm.tir.transform.HoistIfThenElse("basic"),
Review comment:
I don't think a little more compile-time complexity is a real problem.
Perhaps the pass can even be faster than those Python bindings. We can always
perform the "advanced" version as long as it won't break the correctness or do
negative optimizations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
