ANSHUMAN87 commented on a change in pull request #6238:
URL: https://github.com/apache/incubator-tvm/pull/6238#discussion_r476244142
##########
File path: python/tvm/driver/build_module.py
##########
@@ -181,7 +181,7 @@ def lower(sch,
tvm.tir.transform.BF16Legalize(),
tvm.tir.transform.NarrowDataType(32),
tvm.tir.transform.Simplify(),
- tvm.tir.transform.HoistIfThenElse(),
+ tvm.tir.transform.HoistIfThenElse("basic"),
Review comment:
Yes, you are right! The compile-time complexity is not the real point
here. I just shared the info :)
I am okay for the both the approach.
However i think it would be good to have one additional segregation inside
Pass to have more control on the different scenarios it has covered. Which can
provide more user friendly experience, when user wants to club the Pass with
only specific Passes without needing to write special config parameters.
Let us have some more opinion on this point, to conclude better.
@MarisaKirisame : Would please help share your thoughts on above point. TIA!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
