jtuyls commented on a change in pull request #6342:
URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r481052359
##########
File path: docker/bash.sh
##########
@@ -75,6 +75,27 @@ else
CI_PY_ENV=""
fi
+if [[ "${DOCKER_IMAGE_NAME}" == *"demo_vitis_ai"* && -d "/dev/shm" && -d
"/opt/xilinx/dsa" && -d "/opt/xilinx/overlaybins" ]]; then
+ WORKSPACE_VOLUMES="-v /dev/shm:/dev/shm -v /opt/xilinx/dsa:/opt/xilinx/dsa
-v /opt/xilinx/overlaybins:/opt/xilinx/overlaybins"
Review comment:
I like the proposal of @leandron. Would improve clarity in the bash.sh
for multiple devices. We could additionally standardize on variables like
$VITIS_AI_FLAGS, etc to be edited in the function and to be added to the
`docker run` command.
@leandron You specifically want to leave this out of this PR as we could
easily already write our Vitis-AI changes in this format?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
