tqchen commented on a change in pull request #6342:
URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r480441431



##########
File path: docker/bash.sh
##########
@@ -75,6 +75,27 @@ else
     CI_PY_ENV=""
 fi
 
+if [[ "${DOCKER_IMAGE_NAME}" == *"demo_vitis_ai"* && -d "/dev/shm" && -d 
"/opt/xilinx/dsa" && -d "/opt/xilinx/overlaybins" ]]; then
+    WORKSPACE_VOLUMES="-v /dev/shm:/dev/shm -v /opt/xilinx/dsa:/opt/xilinx/dsa 
-v /opt/xilinx/overlaybins:/opt/xilinx/overlaybins"

Review comment:
       OK. Please add some comments on top of the if section to describe the 
set of env being setup. We will need to think about cleanly organize the code 
as we start to add support to more devices, this could be a good starting pt.
   
   Thanks @jtuyls




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to