jtuyls commented on a change in pull request #6342:
URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r480217616
##########
File path: docker/bash.sh
##########
@@ -75,6 +75,27 @@ else
CI_PY_ENV=""
fi
+if [[ "${DOCKER_IMAGE_NAME}" == *"demo_vitis_ai"* && -d "/dev/shm" && -d
"/opt/xilinx/dsa" && -d "/opt/xilinx/overlaybins" ]]; then
+ WORKSPACE_VOLUMES="-v /dev/shm:/dev/shm -v /opt/xilinx/dsa:/opt/xilinx/dsa
-v /opt/xilinx/overlaybins:/opt/xilinx/overlaybins"
Review comment:
The check is indeed Xilinx specific but there are also NVIDIA and GPU
specific checks
(https://github.com/apache/incubator-tvm/blob/d4bfcd4c4f8861f6716406ebae391f9936434c4e/docker/bash.sh#L54)
in the bash.sh so I don't see how this differs. And this is the usual way in
which we setup the docker environment with Vitis-AI. Also, the change shouldn't
affect the other docker environments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
