masahi commented on a change in pull request #7038:
URL: https://github.com/apache/tvm/pull/7038#discussion_r536512913



##########
File path: src/auto_scheduler/search_task.cc
##########
@@ -66,6 +69,11 @@ HardwareParams 
HardwareParamsNode::GetDefaultHardwareParams(const Target& target
 
     device_api->GetAttr(ctx, 
tvm::runtime::DeviceAttrKind::kMaxRegistersPerBlock, &ret);
     int max_registers_per_block = ret;
+    if (max_registers_per_block == 0) {
+      LOG(INFO) << "Device API reported kMaxRegistersPerBlock being 0, using 
the value of "
+                   "kMaxSharedMemoryPerBlock as max_registers_per_block.";

Review comment:
       This is following mercy's suggestion 
https://discuss.tvm.apache.org/t/auto-schedular-performance-on-amdgpu-the-first-attempt/8582/17
   
   Since I also don't understand this issue well, I turned it into a comment 
with more info.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to