merrymercy commented on a change in pull request #7038:
URL: https://github.com/apache/tvm/pull/7038#discussion_r536513796
##########
File path: src/auto_scheduler/search_task.cc
##########
@@ -66,6 +69,13 @@ HardwareParams
HardwareParamsNode::GetDefaultHardwareParams(const Target& target
device_api->GetAttr(ctx,
tvm::runtime::DeviceAttrKind::kMaxRegistersPerBlock, &ret);
int max_registers_per_block = ret;
Review comment:
I think the name "max_registers_per_block" in `HardwareParams` is a bug.
It should be renamed to`max_local_memory_per_block`. Because this is the
only way it is used in `VerifyGPUCode` pass. I can send another PR to fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
