merrymercy commented on a change in pull request #7038:
URL: https://github.com/apache/tvm/pull/7038#discussion_r536514067
##########
File path: src/auto_scheduler/search_task.cc
##########
@@ -66,6 +69,13 @@ HardwareParams
HardwareParamsNode::GetDefaultHardwareParams(const Target& target
device_api->GetAttr(ctx,
tvm::runtime::DeviceAttrKind::kMaxRegistersPerBlock, &ret);
int max_registers_per_block = ret;
Review comment:
This check on local memory should not be used in my option. Autotvm does
not use check local memory either.
##########
File path: src/auto_scheduler/search_task.cc
##########
@@ -66,6 +69,13 @@ HardwareParams
HardwareParamsNode::GetDefaultHardwareParams(const Target& target
device_api->GetAttr(ctx,
tvm::runtime::DeviceAttrKind::kMaxRegistersPerBlock, &ret);
int max_registers_per_block = ret;
Review comment:
The check on local memory should not be used in my option. Autotvm does
not use check local memory either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
