junrushao1994 commented on a change in pull request #7152:
URL: https://github.com/apache/tvm/pull/7152#discussion_r548759022
##########
File path: include/tvm/runtime/packed_func.h
##########
@@ -559,7 +569,18 @@ class TVMMovableArgValue_ : public TVMPODValue_ {
private:
/*! \return The arg value repr of the value. */
- TVMArgValue AsArgValue() const { return TVMArgValue(value_, type_code_); }
+ TVMArgValue AsArgValue() const { return TVMArgValue(value_, type_code_,
prefix_message_); }
+ /*! \brief Construct a message to provide context to any conversion errors
in TVMPODValue_. */
+ static std::string error_string(const std::string& name, int argnum) {
Review comment:
Please do not write a static function in c++ header...Use inline to make
sure only one copy of this function exists after linking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
