tqchen commented on a change in pull request #7152:
URL: https://github.com/apache/tvm/pull/7152#discussion_r552850438
##########
File path: include/tvm/ir/transform.h
##########
@@ -414,6 +414,65 @@ TVM_DLL Pass
CreateModulePass(const runtime::TypedPackedFunc<IRModule(IRModule,
PassContext)>& pass_func,
int opt_level, String name, Array<runtime::String> required);
+class ModulePassNode : public PassNode {
Review comment:
I do think it is possible to keep things as they are(not moving to the
header). Since the original rationale is to bring benefit of isolation. Ideally
we don't want to cut one part to make things easier in another case.
To resolve this, one way is to keep the API in their original form, while
creating a separate function CreateModulePass_ that takes the
`runtime::TypedPackedFunc` which constructs during the templated version.
One possible way is to create an overloaded function of CreateModulePass_
that accepts the runtime::TypedPackedFunc which get calls into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
