tqchen commented on a change in pull request #7152:
URL: https://github.com/apache/tvm/pull/7152#discussion_r552916021



##########
File path: include/tvm/ir/transform.h
##########
@@ -414,6 +414,65 @@ TVM_DLL Pass
 CreateModulePass(const runtime::TypedPackedFunc<IRModule(IRModule, 
PassContext)>& pass_func,
                  int opt_level, String name, Array<runtime::String> required);
 
+class ModulePassNode : public PassNode {

Review comment:
       To clarify. 
   - Have a function (not templated) `CreateModulePass_` that takes in 
`TypedPackedFunc`
   - Create a templated function `CreateModulePass` that constructs the 
function(with name) and call into `CreateModulePass_`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to