jroesch commented on a change in pull request #7419:
URL: https://github.com/apache/tvm/pull/7419#discussion_r572458833
##########
File path: include/tvm/runtime/vm/vm.h
##########
@@ -256,7 +256,7 @@ class VirtualMachine : public runtime::ModuleNode {
*
* This does not begin execution of the VM.
*/
- void InvokeGlobal(const VMFunction& func, const std::vector<ObjectRef>&
args);
+ void InvokeGlobal(const VMFunction& func, Index func_index, const
std::vector<ObjectRef>& args);
Review comment:
I see the code has been refactored, I think we should store the function
index in the function itself so we don't have to pass extra state around and
the VMFunctions are sufficient to construct local state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
