yhj050806 commented on a change in pull request #7419:
URL: https://github.com/apache/tvm/pull/7419#discussion_r572513171
##########
File path: include/tvm/runtime/vm/vm.h
##########
@@ -256,7 +256,7 @@ class VirtualMachine : public runtime::ModuleNode {
*
* This does not begin execution of the VM.
*/
- void InvokeGlobal(const VMFunction& func, const std::vector<ObjectRef>&
args);
+ void InvokeGlobal(const VMFunction& func, Index func_index, const
std::vector<ObjectRef>& args);
Review comment:
in VirtualMachine::InvokeGlobal , function PushFrame is pushing a frame
which include curernt's code_ ,pc_, func_idx_ into VirtualMachine::frames_.
current's code_, pc_ is updated in VirtualMachine::InvokeGlobal. but current
func_idx_ is updated in the entire code . I think func_idx_ should be updated
in VirtualMachine::InvokeGlobal the same way as pc_ and code_. So I pass the
func_idx to the function VirtualMachine::InvokeGlobal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
