yhj050806 commented on a change in pull request #7419:
URL: https://github.com/apache/tvm/pull/7419#discussion_r572509697
##########
File path: include/tvm/runtime/vm/vm.h
##########
@@ -256,7 +256,7 @@ class VirtualMachine : public runtime::ModuleNode {
*
* This does not begin execution of the VM.
*/
- void InvokeGlobal(const VMFunction& func, const std::vector<ObjectRef>&
args);
+ void InvokeGlobal(const VMFunction& func, Index func_index, const
std::vector<ObjectRef>& args);
Review comment:
Because VirtualMachine::func_index_ is not updated in the function
VirtualMachine::InvokeGlobal like VirtualMachine::pc_ does。
or VirtualMachine::func_index_ should be deleted, I'm not seeing any place
that use VirtualMachine::func_index_ in current code。
If VirtualMachine::func_index_ will be used in future。 then
VirtualMachine::func_index_ should be updated in VirtualMachine::InvokeGlobal.
otherwise, the logic is not right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
