tqchen commented on a change in pull request #7488:
URL: https://github.com/apache/tvm/pull/7488#discussion_r581183745
##########
File path: src/runtime/c_runtime_api.cc
##########
@@ -150,15 +150,16 @@ static size_t GetDataAlignment(const DLDataType dtype) {
return align;
}
-void* DeviceAPI::AllocDataSpace(TVMContext ctx, std::vector<int64_t> shape,
DLDataType dtype,
- Optional<String> mem_scope) {
+void* DeviceAPI::AllocDataSpace(TVMContext ctx, int ndim, int64_t* shape,
Review comment:
use const int64_t* (can const cast to DLTensor->shape internally)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
