tqchen commented on a change in pull request #7488:
URL: https://github.com/apache/tvm/pull/7488#discussion_r583149281
##########
File path: include/tvm/runtime/device_api.h
##########
@@ -90,6 +90,17 @@ class TVM_DLL DeviceAPI {
*/
virtual void* AllocDataSpace(TVMContext ctx, size_t nbytes, size_t alignment,
DLDataType type_hint) = 0;
+ /*!
+ * \brief Allocate a data space on device with memory scope support.
+ * \param ctx The device context to perform operation.
+ * \param ndim The number of dimension of allocated tensor.
+ * \param shape The shape of allocated tensor.
+ * \param dtype The type of elements.
+ * \param mem_scope The memory scope of allocated tensor.
+ * \return The allocated device pointer.
+ */
+ virtual void* AllocDataSpace(TVMContext ctx, int ndim, const int64_t* shape,
DLDataType dtype,
+ Optional<String> mem_scope = NullOpt);
Review comment:
The present as string from the interface level because different device
comes with different scoping convention. Internally they are mapped to enum at
each DeviceAPI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
