tqchen commented on a change in pull request #7488:
URL: https://github.com/apache/tvm/pull/7488#discussion_r583163694
##########
File path: src/runtime/rpc/rpc_endpoint.h
##########
@@ -147,8 +146,7 @@ class RPCEndpoint {
* \param ctx_from The source context.
* \param type_hint Hint of content data type.
*/
- void CopyFromRemote(void* from, size_t from_offset, void* to, size_t
to_offset, size_t nbytes,
- TVMContext ctx_from, DLDataType type_hint);
+ void CopyFromRemote(DLTensor* from, void* to_bytes, uint64_t nbytes);
Review comment:
This was discussed in the initial proposal. What we really wanted was a
DLTensor with const void* in the data field. Making const DLTensor* won't
provide much protection as expected, other than the syntax highlighting the
fact that from should be constant.
Eventually I think DLTensor* is fine here to be consistent with
https://github.com/apache/tvm/blob/main/include/tvm/runtime/c_runtime_api.h#L425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
