tqchen commented on a change in pull request #7488:
URL: https://github.com/apache/tvm/pull/7488#discussion_r583996857
##########
File path: src/runtime/crt/common/crt_runtime_api.c
##########
@@ -87,16 +87,33 @@ int TVMDeviceAllocDataSpace(DLContext ctx, size_t nbytes,
size_t alignment, DLDa
if (alignment != 1) {
nbytes = (nbytes + alignment - 1) / alignment * alignment;
}
-
return TVMPlatformMemoryAllocate(nbytes, ctx, out_data);
}
+int TVMDeviceAllocDataSpaceWithScope(DLContext ctx, int ndim, const int64_t*
shape,
+ DLDataType dtype, const char* mem_scope,
void** out_data) {
+ size_t nbytes = 1;
+ for (int i = 0; i < ndim; ++i) {
+ nbytes *= shape[i];
+ }
+ nbytes *= (dtype.bits * dtype.lanes + 7) / 8;
+
+ int kAllocAlignment = 128;
Review comment:
constexpr is not a C keyword, so we might need to keep it as it is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
