masahi commented on a change in pull request #7438:
URL: https://github.com/apache/tvm/pull/7438#discussion_r596555017



##########
File path: tests/scripts/task_python_frontend.sh
##########
@@ -31,6 +31,9 @@ find . -type f -path "*.pyc" | xargs rm -f
 # Rebuild cython
 make cython3
 
+# Only run GPU enabled tests on GPU
+export PYTEST_ADDOPTS="-m gpu $PYTEST_ADDOPTS"

Review comment:
       Are we sure we want this? I think this is skipping a lot of tests that 
were previously running. The GPU frontend test only took 1h 16 min which seems 
too fast to me 
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7438/6/pipeline/390
   
   It seems there are many tests that don't use `@tvm.testing.uses_gpu`. 
https://github.com/apache/tvm/blob/96b09817fc1796a789524ae30cd2d7e9d6f73d6c/tests/python/frontend/pytorch/test_object_detection.py#L93-L94




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to