electriclilies commented on a change in pull request #7438:
URL: https://github.com/apache/tvm/pull/7438#discussion_r597072538



##########
File path: tests/scripts/task_python_frontend.sh
##########
@@ -31,6 +31,9 @@ find . -type f -path "*.pyc" | xargs rm -f
 # Rebuild cython
 make cython3
 
+# Only run GPU enabled tests on GPU
+export PYTEST_ADDOPTS="-m gpu $PYTEST_ADDOPTS"

Review comment:
       Overall, I think that hardcoding targets is bad because it's not easy to 
see -- that's what caused none of the ONNX tests to be run on GPU in the first 
place. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to